Report source location unknown entity type and action errors #802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-h-kastner-aws
force-pushed
the
unknown_entity_type_source_loc
branch
from
461b60b to
fb093f8
Compare
Signed-off-by: John Kastner <[email protected]>
Signed-off-by: John Kastner <[email protected]>
john-h-kastner-aws
force-pushed
the
unknown_entity_type_source_loc
branch
from
61fd636 to
d4d4f68
Compare
Signed-off-by: John Kastner <[email protected]>
|
I have the same comment: #808 (comment) |
shaobo-he-aws
approved these changes
Apr 24, 2024
cdisselkoen
approved these changes
Apr 30, 2024
Signed-off-by: John Kastner <[email protected]>
shaobo-he-aws
approved these changes
Apr 30, 2024
john-h-kastner-aws
added a commit
to cedar-policy/cedar-spec
that referenced
this pull request
May 1, 2024
john-h-kastner-aws
added a commit
to cedar-policy/cedar-spec
that referenced
this pull request
May 1, 2024
Signed-off-by: John Kastner <[email protected]>
john-h-kastner-aws
added a commit
to cedar-policy/cedar-spec
that referenced
this pull request
May 1, 2024
Signed-off-by: John Kastner <[email protected]>
john-h-kastner-aws
added a commit
that referenced
this pull request
May 6, 2024
Signed-off-by: John Kastner <[email protected]>
john-h-kastner-aws
added a commit
that referenced
this pull request
May 7, 2024
Signed-off-by: John Kastner <[email protected]>
john-h-kastner-aws
added a commit
to cedar-policy/cedar-spec
that referenced
this pull request
May 8, 2024
Signed-off-by: John Kastner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
Adds source info onto
NameandEntityUIDstructs and then uses these to report the precise location of the unknown entity type or action.Some refactoring is also posted in seperate PRs that should be merged before this: #803, #804
Fixes #522
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy.I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):