fix for #736 #758
Merged
fix for #736 #758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Disselkoen <[email protected]>
Closed
2 tasks
khieta
approved these changes
Mar 28, 2024
john-h-kastner-aws
approved these changes
Mar 28, 2024
cedar-policy-core/src/ast/policy.rs
Outdated
| match num_slots { | ||
| Some(slot_id) => Err(UnexpectedSlotError::FoundSlot(slot_id))?, | ||
| match first_slot { | ||
| Some(slot) => Err(UnexpectedSlotError::FoundSlot(slot.id))?, |
There was a problem hiding this comment.
I don't think this error is pub use'ed, so could we add the loc to it also?
There was a problem hiding this comment.
this simple idea led to a larger refactor. Re-review needed.
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
john-h-kastner-aws
approved these changes
Mar 29, 2024
shaobo-he-aws
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Better source location for the error mentioned in #736
Issue #, if available
#736
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy-core,cedar-validator, etc.)I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):