improve error when null occurs in entity json data
#751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Disselkoen <[email protected]>
aaronjeline
approved these changes
Mar 28, 2024
john-h-kastner-aws
approved these changes
Mar 28, 2024
| ), | ||
| /// JSON null, which is never valid, but we put this here in order to | ||
| /// provide a better error message. | ||
| Null, |
There was a problem hiding this comment.
Does this just implicitly deserailize from null without additional annotation?
There was a problem hiding this comment.
It does seem so, as shown by this PR's tests
cdisselkoen
added a commit
that referenced
this pull request
Mar 28, 2024
Signed-off-by: Craig Disselkoen <[email protected]>
3 tasks
shaobo-he-aws
pushed a commit
that referenced
this pull request
Mar 29, 2024
Signed-off-by: Craig Disselkoen <[email protected]>
shaobo-he-aws
pushed a commit
that referenced
this pull request
Apr 11, 2024
Signed-off-by: Craig Disselkoen <[email protected]>
shaobo-he-aws
pushed a commit
that referenced
this pull request
Apr 11, 2024
Signed-off-by: Craig Disselkoen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
As it says in the title.
Issue #, if available
Fixes #530
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy-core,cedar-validator, etc.)Not breaking because the error type being changed is not re-exported in
cedar-policy.I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):