Backport #457 to 2.4.x #671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplate' into backport/shaobo/add_template
shaobo-he-aws
requested review from
aaronjeline,
andrewmwells-amazon,
cdisselkoen,
john-h-kastner-aws and
khieta
aaronjeline
approved these changes
Feb 27, 2024
| Now it will not, since we know `{"foo": 5} has bar` is `False`, and the | ||
| validator will return an error for a policy that can never fire. | ||
| - Removed deprecated `__expr` escapes from integration tests. | ||
| - Calling `add_template` with a `PolicyId` that is an existing link will now error. |
There was a problem hiding this comment.
It's more than just add_template right? Also add and link?
There was a problem hiding this comment.
I think this PR just fixes the function. The comments of add and link probably are added to be more informative?
There was a problem hiding this comment.
I agree. this only changes add_template.
john-h-kastner-aws
approved these changes
Feb 28, 2024
| Now it will not, since we know `{"foo": 5} has bar` is `False`, and the | ||
| validator will return an error for a policy that can never fire. | ||
| - Removed deprecated `__expr` escapes from integration tests. | ||
| - Calling `add_template` with a `PolicyId` that is an existing link will now error. |
There was a problem hiding this comment.
I agree. this only changes add_template.
|
I assume the PR title should say 2.4.x instead of 2.5.x? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
#457 contains the fixes of #456 for release 2.4.
Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy.I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):Disclaimer
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.