Skip to content

Conversation

shaobo-he-aws
Copy link
Contributor

@shaobo-he-aws shaobo-he-aws commented Feb 26, 2024

Description of changes

Backported

Issue #, if available

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A bug fix or other functionality change requiring a patch to cedar-policy.

I confirm that this PR (choose one, and delete the other options):

  • Does not update the CHANGELOG because my change does not significantly impact released code.

I confirm that cedar-spec (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.

Disclaimer

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shaobo-he-aws
Copy link
Contributor Author

We need to backport #383 first in order to #386 to work because the latter will enable doc test in the README which wouldn't be correct without the former.

Copy link
Contributor

@john-h-kastner-aws john-h-kastner-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look like one of the rust-doc lints started failing. I guess it's just because of an update to clippy at some point.

Should just need to add back-ticks where it asks for them

@shaobo-he-aws
Copy link
Contributor Author

Look like one of the rust-doc lints started failing. I guess it's just because of an update to clippy at some point.

Should just need to add back-ticks where it asks for them

Yes. I fixed it in #670.

@shaobo-he-aws shaobo-he-aws changed the title Backport #383 and #386 to 2.4.x Backport bug fixes to 2.4.x Feb 26, 2024
@shaobo-he-aws shaobo-he-aws merged commit 8984a76 into release/2.4.x Feb 27, 2024
@shaobo-he-aws shaobo-he-aws deleted the backport/shaobo/2.4.x branch February 27, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants