Fixing #580 (Fully qualify common types in error messages) #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
john-h-kastner-aws
approved these changes
Feb 20, 2024
shaobo-he-aws
approved these changes
Feb 20, 2024
aaronjeline
deleted the
580-undeclaredcommontypes-error-should-always-report-fully-qualfied-name-of-type
branch
khieta
pushed a commit
that referenced
this pull request
Feb 26, 2024
khieta
pushed a commit
that referenced
this pull request
Feb 26, 2024
Signed-off-by: Kesha Hietala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The error message for
UndeclaredCommonTypesnow reports fully qualified type names, which is less confusingIssue #, if available
#580
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy.I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):Disclaimer
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.