Skip to content

increase validator precision in an edge case #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2024
Merged

increase validator precision in an edge case #615

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions cedar-policy-validator/src/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,14 +482,18 @@ impl Type {
}

/// Return true if we know that any value in this type must be a specified
/// entity. An unspecified entity has type `AnyEntity`, so `AnyEntity` might
/// not be specified. Other entity types must be specified.
/// entity.
pub(crate) fn must_be_specified_entity(ty: &Type) -> bool {
matches!(
ty,
// An unspecified entity has type `AnyEntity`, so `AnyEntity` might
// not be specified. Other entity types must be specified.
Type::EntityOrRecord(
EntityRecordKind::Entity(_) | EntityRecordKind::ActionEntity { .. }
)
// It is vacuously true that any value in the type `Never` is a
// specified entity.
| Type::Never
)
}

Expand Down