Skip to content

Conversation

0x00A5
Copy link
Contributor

@0x00A5 0x00A5 commented Jan 22, 2024

Description of changes

Address #474

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A breaking change requiring a major version bump to cedar-policy (e.g., changes to the signature of an existing API).
  • A backwards-compatible change requiring a minor version bump to cedar-policy (e.g., addition of a new API).
  • A bug fix or other functionality change requiring a patch to cedar-policy.
  • A change "invisible" to users (e.g., documentation, changes to "internal" crates like cedar-policy-core, cedar-validator, etc.)
  • A change (breaking or otherwise) that only impacts unreleased or experimental code.

I confirm that this PR (choose one, and delete the other options):

  • Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor version bumps).
  • Does not update the CHANGELOG because my change does not significantly impact released code.

I confirm that cedar-spec (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar Dafny model or DRT infrastructure.
  • Requires updates, and I have made / will make these updates myself. (Please include in your description a timeline or link to the relevant PR in cedar-spec, and how you have tested that your updates are correct.)
  • Requires updates, but I do not plan to make them in the near future. (Make sure that your changes are hidden behind a feature flag to mark them as experimental.)
  • I'm not sure how my change impacts cedar-spec. (Post your PR anyways, and we'll discuss in the comments.)

Disclaimer

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@0x00A5 0x00A5 force-pushed the issue-474-evaluate-policies-with-full-response branch from 4a890cb to 7360c91 Compare January 22, 2024 21:31
@0x00A5 0x00A5 changed the title Add evaluate_policies_partial API for Authorizer [Draft] Add evaluate_policies_partial API for Authorizer Jan 22, 2024
@0x00A5 0x00A5 force-pushed the issue-474-evaluate-policies-with-full-response branch 2 times, most recently from a79bb91 to 6a5b037 Compare January 22, 2024 22:13
@0x00A5 0x00A5 changed the title [Draft] Add evaluate_policies_partial API for Authorizer Add evaluate_policies_partial API for Authorizer Jan 22, 2024
@0x00A5 0x00A5 force-pushed the issue-474-evaluate-policies-with-full-response branch from 6a5b037 to d501251 Compare January 23, 2024 17:19
Copy link
Contributor

@shaobo-he-aws shaobo-he-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aaronjeline aaronjeline merged commit 2bf3a1d into cedar-policy:main Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants