Adds EntityId::new()
#583
Merged
Adds EntityId::new()
#583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 16, 2024 16:05
cdisselkoen
approved these changes
Jan 16, 2024
Co-authored-by: Craig Disselkoen <[email protected]>
| /// All strings are valid [`EntityId`]s, and can be | ||
| /// constructed either using [`EntityId::new`] | ||
| /// or by using the implementation of [`FromStr`]. This implementation is [`Infallible`], so the | ||
| /// parsed [`EntityId`] can be extracted safely. |
There was a problem hiding this comment.
Should probably update the example to use new
There was a problem hiding this comment.
Sure, I want to leave the .parse() example because it's slightly weird to newcomers
There was a problem hiding this comment.
Move the parse example to the FromStr doc string? Most users should be using new to construct this
khieta
approved these changes
Jan 16, 2024
shaobo-he-aws
added a commit
that referenced
this pull request
May 20, 2025
…a `datetime` (#583) Signed-off-by: Shaobo He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds
EntityId::new()Issue #, if available
#553
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy(e.g., addition of a new API).I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):Disclaimer
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.