-
Notifications
You must be signed in to change notification settings - Fork 107
FFI support for partial evaluation (for discussion) #571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Catch up with upstream repo
Merge changes from main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ygrignon-sfdc, thanks for the contribution! We'd all be excited to see partial evaluation added to the json interface (and presumably language bindings later on). We'll take a closer look and get back to you with any comments on the design/code.
- Reworked logic based on feedback
Looks good overall. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I'll start the CI run (but most of the Build Downstream Dependencies
targets are currently expected to fail due an issue in the scripts)
Looking into the build failures. For one, you can run |
The other failures should hopefully be fixed by rebasing to pick up #574 |
@andrewmwells-amazon I rebased my fork and addressed the fmt issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Maybe @aaronjeline wants to look at this also
Signed-off-by: John Kastner <[email protected]>
Description of changes
Adding support for partial evaluation for FFIs via the new json_is_authorized_partial function
Issue #, if available
#570
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy
(e.g., addition of a new API).I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec
(choose one, and delete the other options):Disclaimer
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.