remove Node::as_inner_pair
#508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-h-kastner-aws
approved these changes
Dec 15, 2023
| errs: &mut ParseErrors, | ||
| ) -> Option<ast::Template> { | ||
| let (maybe_policy, src) = self.as_inner_pair(); | ||
| let maybe_policy = self.as_inner(); |
There was a problem hiding this comment.
I might go a step further and inline this with let policy = ... and do the same for similar uses in other functions.
There was a problem hiding this comment.
Planning on that as a followup
khieta
approved these changes
Dec 15, 2023
shaobo-he-aws
pushed a commit
that referenced
this pull request
May 20, 2025
Signed-off-by: Craig Disselkoen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Another refactor relating to the internal type
Node.I don't think
Node::as_inner_pair()was helping. Replaced it with calls toas_inner()and accessingself.locdirectly, which I think is clearer. (In some places, where there are more than oneSourceSpans involved, it makes it super clear which span is being used.)Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy-core,cedar-validator, etc.)I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):Disclaimer
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.