Skip to content

CLI evaluate shows source spans on parse errr #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2023
Merged

CLI evaluate shows source spans on parse errr #501

merged 1 commit into from
Dec 14, 2023

Conversation

@john-h-kastner-aws
Copy link
Contributor

@john-h-kastner-aws john-h-kastner-aws commented Dec 14, 2023 •
edited
Loading

Description of changes

Small change to get the nicely underlined spans for parse errors on cedar evaluate

[jkastner@dev-dsk-jkastner-1a-3309db3b cedar]$ cedar evaluate '1 / 2'
  × failed to parse the expression
  ╰─▶ division is not supported
   ╭────
 1 │ 1 / 2
   · ─────
   ╰────

Issue #, if available

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A bug fix or other functionality change requiring a patch to cedar-policy.

I confirm that this PR (choose one, and delete the other options):

  • Does not update the CHANGELOG because my change does not significantly impact released code.

I confirm that cedar-spec (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar Dafny model or DRT infrastructure.

Disclaimer

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@john-h-kastner-aws john-h-kastner-aws merged commit b383613 into main Dec 14, 2023
@john-h-kastner-aws john-h-kastner-aws deleted the jkastner/err/evaluate branch December 15, 2023 16:45
shaobo-he-aws added a commit that referenced this pull request May 20, 2025
@shaobo-he-aws @adpaco-aws
Enable generation of arbitrary annotations and test their equivalence (…
29382d6 
…#501)

Signed-off-by: Shaobo He <[email protected]>
Co-authored-by: Adrian Palacios <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdisselkoen cdisselkoen cdisselkoen approved these changes

+1 more reviewer

@andrewmwells-amazon andrewmwells-amazon andrewmwells-amazon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@john-h-kastner-aws @cdisselkoen @andrewmwells-amazon