use miette::SourceSpan directly in many places
#470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-h-kastner-aws
approved these changes
Dec 7, 2023
3 tasks
cdisselkoen
force-pushed
the
cdisselkoen/direct-sourcespan
branch
from
23795ca to
6a12d16
Compare
cdisselkoen
force-pushed
the
cdisselkoen/direct-sourcespan
branch
from
6a12d16 to
1746239
Compare
john-h-kastner-aws
approved these changes
Dec 8, 2023
shaobo-he-aws
added a commit
that referenced
this pull request
May 20, 2025
Signed-off-by: Shaobo He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Instead of our own
SourceInfostruct, we can usemiette::SourceSpandirectly. This provides some efficiency, and allows removing the code and impls forSourceInfo.This will also make #182 easier.
This PR also swaps the values in the return pair of
ASTNode::as_inner_pair()for consistency withASTNode::into_inner().Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy-core,cedar-validator, etc.)I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):Disclaimer
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.