disallow duplicate keys in FFI, integration testing #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-h-kastner-aws
approved these changes
Nov 17, 2023
| /// `__entity` and `__extn` escapes to be implicit, and it will error if | ||
| /// attributes have the wrong types (e.g., string instead of integer). | ||
| #[serde(rename = "schema")] | ||
| schema: Option<serde_json::Value>, |
There was a problem hiding this comment.
Schema parsing should already be forbidding duplicate keys everywhere, so this should just move the error message around a bit. I don't see anything wrong with that, and consistently using the no-duplicates variant is nice, but maybe think about if the new error is substantially better/worse than before.
There was a problem hiding this comment.
I don't think that's the case. serde_json::Value cannot contain duplicate keys, so any schema parsing that accepts serde_json::Value won't ever see the duplicate keys -- they would already be silently dropped (last-value-wins) during whatever process created the serde_json::Value.
andrewmwells-amazon
approved these changes
Nov 17, 2023
shaobo-he-aws
added a commit
that referenced
this pull request
May 20, 2025
Signed-off-by: Shaobo He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
using the already existing
JsonValueWithNoDuplicateKeyscreated for CoreIssue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy-core,cedar-validator, etc.)I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):Disclaimer
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.