Adds ability to Merge policy sets with the option to rename policy id's upon duplicate ids. #1476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charlie Murphy <[email protected]>
Signed-off-by: Charlie Murphy <[email protected]>
…t tests. Signed-off-by: Charlie Murphy <[email protected]>
Signed-off-by: Charlie Murphy <[email protected]>
Signed-off-by: Charlie Murphy <[email protected]>
chaluli
force-pushed
the
merge_policy_sets
branch
from
03d8350 to
917cd70
Compare
Signed-off-by: Charlie Murphy <[email protected]>
chaluli
force-pushed
the
merge_policy_sets
branch
from
a559d5b to
a393172
Compare
adpaco-aws
reviewed
Feb 17, 2025
…dress other comments by Adrian. Signed-off-by: Charlie Murphy <[email protected]>
Signed-off-by: Charlie Murphy <[email protected]>
adpaco-aws
approved these changes
Feb 18, 2025
Signed-off-by: Charlie Murphy <[email protected]> Co-authored-by: Adrian Palacios <[email protected]>
john-h-kastner-aws
approved these changes
Feb 18, 2025
…shmaps. Addresses John's comments. Signed-off-by: Charlie Murphy <[email protected]>
john-h-kastner-aws
approved these changes
Feb 18, 2025
2 tasks
jv-garcia
pushed a commit
to jv-garcia/cedar
that referenced
this pull request
May 6, 2025
…'s upon duplicate ids. (cedar-policy#1476) Signed-off-by: Charlie Murphy <[email protected]> Co-authored-by: Adrian Palacios <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds the ability to merge a two policy sets. The user can choose to either have conflicting policy ids result in an error or to be automatically renamed. The renaming scheme is returned as a HashMap from the old id to the newly auto-generated id.
Issue #610
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy(e.g., addition of a new API).I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):I confirm that
docs.cedarpolicy.com(choose one, and delete the other options):