Apply clippy auto-fixes #1185
Merged
Apply clippy auto-fixes #1185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shaobo He <[email protected]>
shaobo-he-aws
requested review from
cdisselkoen,
john-h-kastner-aws,
khieta,
aaronjeline and
andrewmwells-amazon
and removed request for
john-h-kastner-aws
john-h-kastner-aws
approved these changes
Sep 9, 2024
| entity_children | ||
| .entry(internal_name_to_entity_type(parent.clone())?) | ||
| .or_insert_with(HashSet::new) | ||
| .or_default() |
There was a problem hiding this comment.
Can you check if this is actually the same? I can imagine that or_default could reasonably not insert the default value
There was a problem hiding this comment.
It seems or_default does the job: https://doc.rust-lang.org/std/collections/hash_map/enum.Entry.html#method.or_default
aaronjeline
pushed a commit
that referenced
this pull request
Sep 10, 2024
Signed-off-by: Shaobo He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Applied clippy 1.81
Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy-core,cedar-validator, etc.)I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):