implement schema-format parsers for RFC 68 #1136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Disselkoen <[email protected]>
|
There are merge conflicts. Could you resolve them? |
|
Working on it |
…rsers Signed-off-by: Craig Disselkoen <[email protected]>
|
Merge conflicts fixed |
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
john-h-kastner-aws
approved these changes
Aug 10, 2024
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
shaobo-he-aws
approved these changes
Aug 14, 2024
Signed-off-by: Craig Disselkoen <[email protected]>
shaobo-he-aws
approved these changes
Aug 14, 2024
john-h-kastner-aws
approved these changes
Aug 15, 2024
cdisselkoen
added a commit
that referenced
this pull request
Sep 13, 2024
This reverts commit e63f663. Signed-off-by: Craig Disselkoen <[email protected]>
cdisselkoen
added a commit
that referenced
this pull request
Sep 13, 2024
This reverts commit e63f663. Signed-off-by: Craig Disselkoen <[email protected]>
cdisselkoen
added a commit
that referenced
this pull request
Sep 13, 2024
This reverts commit e63f663. Signed-off-by: Craig Disselkoen <[email protected]>
3 tasks
cdisselkoen
added a commit
that referenced
this pull request
Sep 13, 2024
This reverts commit e63f663. Signed-off-by: Craig Disselkoen <[email protected]>
cdisselkoen
added a commit
that referenced
this pull request
Sep 13, 2024
Signed-off-by: Craig Disselkoen <[email protected]>
shaobo-he-aws
pushed a commit
that referenced
this pull request
Sep 25, 2024
Signed-off-by: Craig Disselkoen <[email protected]>
This was referenced Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Implements the needed changes for RFC 68 in the parsers for both schema formats (Cedar schema format and JSON schema format). Includes tests that things parse properly and that invalid uses of embedded attribute maps correctly fail to parse. Does not include any changes to the validator/typechecker itself; those will come in a future PR. These parser changes are reasonably separable though, and this PR is large enough as-is.
With this PR, if anyone tries to use the new RFC 68 syntax, instead of an incomprehensible parser error, they will get a nice message saying that embedded attribute maps are not fully supported yet.
Issue #, if available
Part of #1104
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy.I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):cedar-spec, and how you have tested that your updates are correct.)