Unify the signature of PolicySet::annotation and PolicySet::template_annotation
#1131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te_annotation` Signed-off-by: Shaobo He <[email protected]>
Signed-off-by: Shaobo He <[email protected]>
2 tasks
shaobo-he-aws
requested review from
cdisselkoen,
john-h-kastner-aws,
khieta,
aaronjeline and
andrewmwells-amazon
khieta
approved these changes
Aug 8, 2024
cdisselkoen
approved these changes
Aug 9, 2024
Comment on lines
460
to
468
| /// Lookup a template by policy id | ||
| /// Lookup a template by policy id, returns [`Option<Arc<Template>>`] | ||
| pub fn get_template(&self, id: &PolicyID) -> Option<Arc<Template>> { | ||
| self.templates.get(id).cloned() | ||
| } | ||
|
|
||
| /// Lookup a template by policy id, returns [`Option<&Template>`] | ||
| pub fn get_template_ref(&self, id: &PolicyID) -> Option<&Template> { | ||
| self.templates.get(id).map(AsRef::as_ref) | ||
| } |
There was a problem hiding this comment.
I think in other places we call these get_template_arc and just get_template. Should we change the other places to match this convention?
There was a problem hiding this comment.
I think get_template_arc and get_template make more sense to me.
Signed-off-by: Shaobo He <[email protected]>
Signed-off-by: Shaobo He <[email protected]>
cdisselkoen
approved these changes
Aug 9, 2024
shaobo-he-aws
deleted the
1116-make-policy-and-template-apis-consistent-wrt-annotations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR change the return type to both methods to
Option<&str>. Due to the author's limited knowledge of Rust, I have to add a new function in core to get a reference to theTemplate. Otherwise we could let the return type beOption<SmolStr>.Issue #, if available
#1116
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy(e.g., changes to the signature of an existing API).I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):