use PolicyId
when constructing policies
#1055
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Policy::parse
andTemplate::parse
APIs to use anOption<PolicyId>
instead ofOption<String>
to set the policy idparse_policy*
APIs similarlyPolicyId::new
instead ofPolicyId::from_str
because it's prettierThe diff is largely just the result of updating test cases. The only interesting edits are in:
cedar-policy-core/src/parser.rs
cedar-policy/CHANGELOG.md
cedar-policy/src/api.rs
cedar-policy/src/api/id.rs
cedar-policy/src/ffi/utils.rs
Issue #, if available
Resolves #1049
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy
(e.g., changes to the signature of an existing API).I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec
(choose one, and delete the other options):cedar-spec
, and how you have tested that your updates are correct.)