Fix deserialization for AnyId
#1004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #994 Signed-off-by: John Kastner <[email protected]>
john-h-kastner-aws
force-pushed
the
any_id_deser
branch
from
545263b to
d569c24
Compare
| impl<'de> serde::de::Visitor<'de> for AnyIdVisitor { | ||
| type Value = AnyId; | ||
|
|
||
| fn expecting(&self, formatter: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { |
There was a problem hiding this comment.
Nit: could it be more descriptive than any id?
There was a problem hiding this comment.
I'm not actually sure where this appears in errors. If it doesn't parse then it uses the custom error, and if it's not a string it gives a serde error that doesn't include this expecting text.
shaobo-he-aws
approved these changes
Jun 18, 2024
cdisselkoen
approved these changes
Jun 19, 2024
aaronjeline
pushed a commit
that referenced
this pull request
Aug 2, 2024
Signed-off-by: John Kastner <[email protected]>
aaronjeline
pushed a commit
that referenced
this pull request
Aug 2, 2024
Signed-off-by: John Kastner <[email protected]> Signed-off-by: Aaron Eline <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes #994. Mostly a copy-paste of deser impl for
Id.Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy(e.g., changes to the signature of an existing API).cedar-policy(e.g., addition of a new API).cedar-policy.cedar-policy-core,cedar-validator, etc.)I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):cedar-spec, and how you have tested that your updates are correct.)cedar-spec. (Post your PR anyways, and we'll discuss in the comments.)