Skip to content

Fixes DateTime to handle extreme time zones #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixes DateTime to handle extreme time zones #334

wants to merge 3 commits into from

Conversation

muditchaudhary
Copy link
Contributor

Overview

Fixes DateTime (#328) to support extreme time zones. Java DateTIme cannot handle extreme timezones (E.g., +2359, -2359). However, these are valid in Cedar. It now support all valid Cedar Datetime values 0000-01-01T00:00:00+2359 to 9999-12-31T23:59:59-2359.

Changes

  • Introduces additional parsing methods to handle timezones instead of relying on Java DateTime.
  • Adds comprehensive tests to validate the changes. Borrows some Datetime tests from Cedar-spec

@muditchaudhary muditchaudhary marked this pull request as ready for review October 1, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaobo-he-aws shaobo-he-aws shaobo-he-aws approved these changes

@mark-creamer-amazon mark-creamer-amazon Awaiting requested review from mark-creamer-amazon

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muditchaudhary @shaobo-he-aws