-
Notifications
You must be signed in to change notification settings - Fork 32
Update README.md #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/4.0.x
Are you sure you want to change the base?
Update README.md #218
Conversation
Update readme to match template. Signed-off-by: Clay King <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some small issues
# GitHub Model | ||
|
||
In this example, we show how you can implement GitHub's repository permission access in Cedar. There are three “views” of GitHub permissions, corresponding to *Personal*, *Organization* and *Enterprise* accounts. We’ll focus on the *Organizational* view. Our model won’t be complete since this is a tutorial. We’ll aim for a subset of features that you are probably familiar with. | ||
In this example, GitHub's repository permissions are implemented. . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra .
here
### `pull` | ||
Pull a repository. | ||
|
||
### `push` | ||
Push a repository. | ||
|
||
### `fork` | ||
Fork a repository. | ||
|
||
### `add_{reader, triager, writer, maintainer, admin}` | ||
Add a user to the specified role of a repository. | ||
|
||
### `{create, delete, assign}_issue` | ||
Perform the specified operation on an issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure we should be using subsections in this case. It doesn't match what we do in the rest of the document (e.g., with entity types) and the description is too short for a subsection.
#### Action for Writers: | ||
|
||
A `User` of role `Writer` should be able to push to a repository and also edits its issues. | ||
`User` entities with a role of `Writer` should be able to push to a repository and also edits its issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`User` entities with a role of `Writer` should be able to push to a repository and also edits its issues. | |
`User` entities with a role of `Writer` should be able to push to a repository and also edit their issues. |
* The 1 `Organization` entity, `tiny_corp_owners`, has admin priveleges to all 3 repositories. | ||
* The 1 `Team` entity, `team_that_can_read_everything`, has read priveleges to all 3 repositories. | ||
|
||
Here are some authz requests to test, included in the `ALLOW` and `DENY` folders: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why abbreviate here?
Here are some authz requests to test, included in the `ALLOW` and `DENY` folders: | |
Here are some authorization requests to test, included in the `ALLOW` and `DENY` folders: |
* The 1 `Team` entity, `team_that_can_read_everything`, has read priveleges to all 3 repositories. | ||
|
||
Here are some authz requests to test, included in the `ALLOW` and `DENY` folders: | ||
* Alice tries to pull common_knowledge: ALLOW because she has read permissions through the `common_knowledge_writers` user group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you're using the name with an underscore, I'd use backticks - so either
* Alice tries to pull common_knowledge: ALLOW because she has read permissions through the `common_knowledge_writers` user group. | |
* Alice tries to pull common knowledge: ALLOW because she has read permissions through the `common_knowledge_writers` user group. |
or
* Alice tries to pull common_knowledge: ALLOW because she has read permissions through the `common_knowledge_writers` user group. | |
* Alice tries to pull `common_knowledge`: ALLOW because she has read permissions through the `common_knowledge_writers` user group. |
Same comments goes for the next two cases (with uncommon_knowledge
).
Update readme to match template.
Signed-off-by: Clay King [email protected]