Update for annotations without values #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khieta
approved these changes
Oct 2, 2024
Signed-off-by: John Kastner <[email protected]>
Co-authored-by: Kesha Hietala <[email protected]>
john-h-kastner-aws
force-pushed
the
annotations_update
branch
from
0f7bd24 to
efdf65c
Compare
|
4.2 should go out today, so ready for review and merge immediately after |
cdisselkoen
approved these changes
Oct 7, 2024
|
|
||
| ``` | ||
| Annotation ::= '@'ANYIDENT'('STR')' | ||
| Annotation ::= '@'ANYIDENT' ( ('STR')' )? |
There was a problem hiding this comment.
not sure normal conventions for this grammar syntax, but is this clear that the entire element is optional, and not just the final )?
There was a problem hiding this comment.
I think it's clear, but I did have a ' in the wrong place, so maybe it's more clear now
Move `'` in grammar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Update for cedar-policy/cedar#1231
Draft PR pending release for that feature
Description of changes: