Add possibility to diff states in dumping symbexec state #1311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serpilliere
reviewed
Nov 24, 2020
| """ | ||
|
|
||
| for variable, value in self.modified(None, ids, mems): | ||
| for variable, value in self.modified(dict(init_state_engine if init_state_engine is not None else {}), ids, mems): |
There was a problem hiding this comment.
Maybe the patch be better with:
def dump(self,init_state=None, ids=True, mems=True)
...
if init_state is None:
init_state ={}
...
for variable, value in self.modified(init_state, ids, mems):
....Is it ok for you ?
There was a problem hiding this comment.
Hmmm just note that modified doesnt take in a state instance as the name implies but a base dictionary as its commented in the source code (so a dict(state) )
@init_state: a base dictionary linking variables to their initial values
So I guess passing dict() of a StateEngine or correcting the modified func as well.
There was a problem hiding this comment.
Well, as the state is a kind of dictionary, I may keep the dictionary as argument if you are ok with this (the .symbols return a dictionary as well)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add possibility to diff states in dump func of symbexec