fix: use standard main function on MinGW #2441
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2.x #2441 +/- ##
=======================================
Coverage 90.08% 90.08%
=======================================
Files 113 113
Lines 5040 5040
=======================================
Hits 4540 4540
Misses 500 500 |
aminya
added a commit
to aminya/cpp_vcpkg_project
that referenced
this pull request
Jun 2, 2022
aminya
commented
Jun 30, 2022
|
Hello there, first of all thank you for your PR. |
|
Fixed the conflicts so that it could be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Once you define the
CATCH_CONFIG_MAINdefinition on MinGW, it defines a non-standard main function called WinMain. This results in a lot of undefined references. This doesn't happen with other compilers.This check ensures that the standard main file is used with MinGW.
GitHub Issues
Fixes #2437