Remove Castle.Core.Internal.CollectionExtensions
#563
Merged
+58
−153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakx
force-pushed
the
collection-extensions
branch
from
286ea1f to
b42bc55
Compare
stakx
changed the title
CollectionExtensionsCastle.Core.Internal.CollectionExtensions
Its five methods are dealt with as follows: * `Find`, `IsNullOrEmpty`: unused. * `FindAll`: used only once, inlined. * `GetContentsHashCode`, `AreEquivalent`: used to implement equality contract in `ProxyGenerationOptions`. Moved there, mostly unchanged.
stakx
force-pushed
the
collection-extensions
branch
from
b42bc55 to
9168acf
Compare
stakx
commented
Jan 19, 2021
Comment on lines
-299
to
+296
| result = 29*result + CollectionExtensions.GetContentsHashCode(AdditionalAttributes); | ||
| result = 29*result + GetAdditionalAttributesHashCode(); |
Member
Author
There was a problem hiding this comment.
GetHashCode does not have to be precise (only fast), so we could just use AdditionalAttributes.Count instead of summing the attributes' hash codes. I've not done so because there are some unit tests affected by it; someone in the past must have thought it important that options.GetHashCode differ for different attributes.
This was referenced May 10, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #560.
Its five methods are dealt with as follows:
Find,IsNullOrEmpty: unused.FindAll: used only once, inlined.GetContentsHashCode,AreEquivalent: used to implement equality contract inProxyGenerationOptions. Moved there, mostly unchanged.