Introduce Submission bot & refactor bot feature, invite submission bot to a room #3821

richardhjtan · 2026-01-12T10:20:51Z

github-actions · 2026-01-12T10:21:56Z

Host Test Results

0 files - 1 0 suites - 1 0s ⏱️ - 1h 33m 19s
0 tests - 1 651 0 ✅ - 1 634 0 💤 - 15 0 ❌ - 1
0 runs - 1 665 0 ✅ - 1 647 0 💤 - 15 0 ❌ - 2

Results for commit 979b6af. ± Comparison against base commit c0eb977.

Copilot

Pull request overview

This PR introduces a new submission bot for handling pull request submissions and refactors shared bot functionality into a reusable @cardstack/bot-core package. The submission bot can be invited to Matrix rooms to assist with submission workflows, and the refactoring reduces code duplication between bot services.

Changes:

Created @cardstack/bot-core package with shared utilities for Matrix bot services (client setup, room locking, shutdown handling, signal handlers, sliding sync, auto-join)
Implemented new @cardstack/submission-bot service for handling PR submissions and review workflows
Refactored @cardstack/ai-bot to use the new bot-core utilities, eliminating duplicate code
Added InviteSubmissionBotCommand in the host app to invite the submission bot to rooms with context
Added "Submit for Review" menu item to Listing cards in the catalog realm

Reviewed changes

Copilot reviewed 30 out of 31 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
packages/bot-core/*	New shared package with Matrix bot utilities including client setup, room locking, shutdown/signal handlers, sliding sync, and membership management
packages/submission-bot/*	New bot service for handling submissions with room state context, greeting messages, and command handling
packages/ai-bot/main.ts	Refactored to use bot-core utilities instead of local implementations
packages/ai-bot/lib/signal-handlers.ts	Removed - moved to bot-core
packages/ai-bot/lib/shutdown.ts	Removed - moved to bot-core
packages/ai-bot/package.json	Added bot-core dependency
packages/host/app/commands/invite-submission-bot.ts	New command for inviting submission bot with context stored in room state
packages/host/app/commands/index.ts	Registered new InviteSubmissionBotCommand
packages/host/app/services/matrix-service.ts	Added submissionBotUserId getter and inviteToRoom method
packages/host/app/resources/room.ts	Updated to check for both AI bot and submission bot membership
packages/host/app/components/matrix/room.gts	Updated generatingResults to only show for AI bot streaming messages
packages/catalog-realm/catalog-app/listing/listing.gts	Added "Submit for Review" menu item using InviteSubmissionBotCommand
packages/runtime-common/constants.ts	Added submissionBotUsername constant
packages/base/command.gts	Added InviteSubmissionBotInput type definition
packages/matrix/package.json	Added register-submission-bot script and updated register-all
.github/workflows/ci-lint.yaml	Added linting steps for bot-core and submission-bot
pnpm-lock.yaml	Updated dependencies and lockfile entries

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-12T10:30:50Z

packages/catalog-realm/catalog-app/listing/listing.gts

+        try {
+          await new InviteSubmissionBotCommand(commandContext).execute({
+            submissionTarget: cardId,
+            submissionType: 'listing',


The submissionType is set to 'listing' here, but the SubmissionContext interface in submission-bot/main.ts only allows 'pull-request', 'card', or 'other'. This will cause the type to fall through to the default case in the switch statement. Either update the SubmissionContext type to include 'listing', or map 'listing' to 'card' since listings are cards.

Suggested change

submissionType: 'listing',

submissionType: 'card',

Copilot · 2026-01-12T10:30:50Z

packages/bot-core/.eslintrc.js

+      legacyDecorators: true,
+    },
+  },
+  plugins: ['ember'],


The 'ember' plugin is included in the plugins array but this is not an Ember package - it's a pure Node.js/TypeScript utility package. The ember plugin should be removed since it's not needed for bot-core.

Suggested change

plugins: ['ember'],

Copilot · 2026-01-12T10:30:51Z

packages/submission-bot/.eslintrc.js

+      legacyDecorators: true,
+    },
+  },
+  plugins: ['ember'],


The 'ember' plugin is included in the plugins array but this is not an Ember package - it's a pure Node.js/TypeScript bot service. The ember plugin should be removed since it's not needed for submission-bot.

Suggested change

plugins: ['ember'],

Copilot · 2026-01-12T10:30:51Z

packages/bot-core/.eslintrc.js

+    ecmaFeatures: {
+      legacyDecorators: true,
+    },


The legacyDecorators feature is enabled but this package doesn't use decorators. Since this is a utility package for Matrix bot services without class decorators, this setting can be removed.

Suggested change

ecmaFeatures: {

legacyDecorators: true,

},

Copilot · 2026-01-12T10:30:51Z

packages/host/app/commands/invite-submission-bot.ts

+
+// Room state event type for submission context
+const SUBMISSION_CONTEXT_EVENT_TYPE = 'com.cardstack.submission_context';
+


The constant SUBMISSION_CONTEXT_EVENT_TYPE is duplicated between this file and packages/submission-bot/main.ts. Consider defining this constant in a shared location like @cardstack/runtime-common/matrix-constants to ensure consistency and avoid potential mismatches.

Suggested change

// Room state event type for submission context

const SUBMISSION_CONTEXT_EVENT_TYPE = 'com.cardstack.submission_context';

import { SUBMISSION_CONTEXT_EVENT_TYPE } from '@cardstack/runtime-common/matrix-constants';

Copilot · 2026-01-12T10:30:52Z

packages/host/app/commands/invite-submission-bot.ts

+      '', // empty state key
+    );
+
+    // Open the AI assistant panel with the new room


The comment mentions "AI assistant panel" but this is the submission bot command which opens a room for submission review, not the AI assistant. The comment should be updated to reflect the actual purpose, for example: "Open the room for submission review" or "Open the chat panel with the new submission room".

Suggested change

// Open the AI assistant panel with the new room

// Open the chat panel with the new submission review room

Copilot · 2026-01-12T10:30:52Z

packages/bot-core/package.json

+    "lint:js:fix": "eslint . --report-unused-disable-directives --fix",
+    "lint:glint": "glint"


The lint:glint script is included but bot-core is a pure TypeScript package without Glint templates. This script should be removed as it's not applicable to this package.

Suggested change

"lint:js:fix": "eslint . --report-unused-disable-directives --fix",

"lint:glint": "glint"

"lint:js:fix": "eslint . --report-unused-disable-directives --fix"

Copilot · 2026-01-12T10:30:52Z

packages/submission-bot/package.json

+    "lint:fix": "concurrently \"pnpm:lint:*:fix\" --names \"fix:\"",
+    "lint:js": "eslint . --report-unused-disable-directives --cache",
+    "lint:js:fix": "eslint . --report-unused-disable-directives --fix",
+    "lint:glint": "glint",


The lint:glint script is included but submission-bot is a pure TypeScript package without Glint templates. This script should be removed as it's not applicable to this package.

Suggested change

"lint:glint": "glint",

Copilot · 2026-01-12T10:30:53Z

packages/submission-bot/.eslintrc.js

+    ecmaFeatures: {
+      legacyDecorators: true,
+    },


The legacyDecorators feature is enabled but this package doesn't use decorators. Since this is a bot service without class decorators, this setting can be removed.

Suggested change

ecmaFeatures: {

legacyDecorators: true,

},

Copilot · 2026-01-12T10:30:53Z

packages/submission-bot/main.ts

+} from '@cardstack/bot-core';
+import { PgAdapter } from '@cardstack/postgres';
+import * as Sentry from '@sentry/node';
+


Sentry is imported and used for error capture but never initialized. The submission bot should either initialize Sentry (similar to how ai-bot has an instrument.ts file that calls Sentry.init) or remove the Sentry import and error capture calls if not needed.

Suggested change

if (process.env.SENTRY_DSN) {

Sentry.init({

dsn: process.env.SENTRY_DSN,

tracesSampleRate: 1.0,

});

}

tintinthong · 2026-01-13T09:03:22Z

packages/base/command.gts

 export class OpenAiAssistantRoomInput extends CardDef {
  @field roomId = contains(StringField);
 }



the invite command shud invite any user. This input can be a subclass if neeeded

submissionTarget and submissionType are obviously part of submission bot only

tintinthong · 2026-01-13T09:04:39Z

packages/host/app/commands/invite-submission-bot.ts

+// Room state event type for submission context
+const SUBMISSION_CONTEXT_EVENT_TYPE = 'com.cardstack.submission_context';
+
+export default class InviteSubmissionBotCommand extends HostBaseCommand<


this should be invite user to room (roomId)

richardhjtan added 2 commits January 12, 2026 18:18

Submission bot and refactor bot core feature

d522fb1

Invite Submission bot command

979b6af

richardhjtan requested a review from Copilot January 12, 2026 10:20

Copilot started reviewing on behalf of richardhjtan January 12, 2026 10:21 View session

Copilot AI reviewed Jan 12, 2026

View reviewed changes

tintinthong reviewed Jan 13, 2026

View reviewed changes


		// Room state event type for submission context
		const SUBMISSION_CONTEXT_EVENT_TYPE = 'com.cardstack.submission_context';

	// Open the AI assistant panel with the new room
	// Open the chat panel with the new submission review room

		"lint:js:fix": "eslint . --report-unused-disable-directives --fix",
		"lint:glint": "glint"

+if (process.env.SENTRY_DSN) {
+  Sentry.init({
+    dsn: process.env.SENTRY_DSN,
+    tracesSampleRate: 1.0,
+  });
+}

Introduce Submission bot & refactor bot feature, invite submission bot to a room #3821

Are you sure you want to change the base?

Introduce Submission bot & refactor bot feature, invite submission bot to a room #3821

Uh oh!

Conversation

richardhjtan commented Jan 12, 2026

Uh oh!

github-actions bot commented Jan 12, 2026

Host Test Results

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

tintinthong Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

tintinthong Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

tintinthong Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants