Entry/Item level attributes #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance to add same functionality on feed level in addition to item level? I have quiet a few instances where I need to parse channel attributes. |
driv3r
added a commit
to driv3r/simple-rss
that referenced
this pull request
Sep 16, 2013
Also merged pull requests cardmagic#7, cardmagic#12 and cardmagic#13 from upstream repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed the ability to grab attributes off the entry or item tag...and as far as I could tell there isn't currently a way to do this. I've added the change needed and tests behind it. (Let me know if you'd like me to move my tests from their own file back into base_test.)
I'm not sure if such a thing is needed by anybody else...or if it's even in spec for atom/rss, but I'm aggregating some Google Reader Shared feeds, and they have them and I need them. (Example: http://www.google.com/reader/public/atom/user/13184750814515218749/state/com.google/broadcast)
Tested on Ruby 1.8.7p174. Thx.