-
Notifications
You must be signed in to change notification settings - Fork 1k
[Fix] blog tag warnings and truncation to address build warnings #1589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice... I checked in local build ✅ and it has't been this clean in a while! Only warnings still remaining are:
[WARNING] Docusaurus found broken links!
...[WARNING] Docusaurus found broken anchors!
...
@rphair will be addresssing them in the following PR too in 5-10 minutes :) |
withholding review pending style features: canonical lowercase + no truncate video pages
We need some documentation on https://developers.cardano.org/docs/portal-contribute for this |
@katomm I went ahead and fixed both issues. All uppercase tags are now lowercase in the blog posts and I added some contribution guidelines to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked in local build ✅ and everything looks & works great: blog is at least as good as before, with clear explanations of tags & truncation at /docs/portal-contribute#blog-contributions
.
One improvement for contributors (and probably to keep our CI logs clear as well) would be to add onUntruncatedBlogPosts: 'ignore'
to the blog plugin; seen in the build process:
[WARNING] Docusaurus found blog posts without truncation markers:
...
We recommend using truncation markers (`<!-- truncate -->` or `{/* truncate */}`) in blog posts to create shorter previews on blog paginated lists.
Tip: turn this security off with the `onUntruncatedBlogPosts: 'ignore'` blog plugin option.
Added Build warnings should now be cleaner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely cleaner 🤓 ... only 2 warnings I see in local build now are (outside the scope of this PR):
This one has been around for a while:
[WARNING] The image at "/home/rphair/archive/build/developer-portal/static/img/nfts/overview_nfts.svg" can't be read correctly. Please ensure it's a valid image.
unsupported file type: undefined (file: /home/rphair/archive/build/developer-portal/static/img/nfts/overview_nfts.svg)
[WARNING] The image at "/home/rphair/archive/build/developer-portal/static/img/nfts/overview_nfts.svg" can't be read correctly. Please ensure it's a valid image.
unsupported file type: undefined (file: /home/rphair/archive/build/developer-portal/static/img/nfts/overview_nfts.svg)
Needs periodic tune-up, as last we did here (to my knowledge):
Browserslist: browsers data (caniuse-lite) is 8 months old. Please run:
npx update-browserslist-db@latest
Why you should do it regularly: https://github.com/browserslist/update-db#readme
p.s. Fixed by #1610.
Checklist
yarn build
after adding my changes without getting any errors.yarn.lock
(or have removed these changes).Updating documentation or Bugfix
Fixes build warnings regarding to blogs
Changes Made
11 tag warnings affecting SEO and categorization
Fix case sensitivity (AI → ai, DeFi → defi) and add missing media tag
Files: blog/tags.yml + affected blog posts
8 posts without preview truncation
Add markers to recent posts
Files: Blog posts from 2025