Skip to content
This repository was archived by the owner on Mar 8, 2023. It is now read-only.

Conversation

@abdonrd
Copy link
Collaborator

@abdonrd abdonrd commented Nov 11, 2021

  • Now using Prettier v2!

  • I have also started to format the .ts.
    They were already in lint-staged, but not in the yarn format script.

  • I also had to remove eslint-config-carbon-base because it uses outdated dependencies.
    But I have migrated the small config.

@abdonrd abdonrd requested a review from a team as a code owner November 11, 2021 12:01
@abdonrd abdonrd requested review from andysherman2121, annawen1 and photodow and removed request for a team November 11, 2021 12:01
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 11, 2021

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 11, 2021

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 11, 2021

@ibmdotcom-bot
Copy link
Contributor

@abdonrd abdonrd added the Ready to merge Label for the pull requests that are ready to merge label Nov 11, 2021
@abdonrd abdonrd requested a review from jeffchew November 11, 2021 12:51
"format:diff": "prettier --check \"**/*.{css,js,md,scss}\"",
"format": "prettier --write \"**/*.{css,js,ts,md,scss}\"",
"format:diff": "prettier --check \"**/*.{css,js,ts,md,scss}\"",
"format:staged": "prettier --write",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have also started to format the .ts.
They were already in lint-staged, but not in the yarn format script.

"postcss-loader": "^3.0.0",
"postcss-selector-parser": "^6.0.0",
"prettier": "^1.19.0",
"prettier": "~2.4.1",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now using Prettier v2!

"es6-promise": "^4.2.8",
"eslint": "^7.32.0",
"eslint-config-airbnb-base": "^14.2.1",
"eslint-config-carbon-base": "^1.0.1",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also had to remove eslint-config-carbon-base because it uses outdated dependencies.
But I have migrated the small config.

@kodiakhq kodiakhq bot merged commit 2fc244c into master Nov 15, 2021
@kodiakhq kodiakhq bot deleted the eslint-prettier branch November 15, 2021 14:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Ready to merge Label for the pull requests that are ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants