- 
                Notifications
    You must be signed in to change notification settings 
- Fork 161
Definition of done (Visual QA checklist)
        Shixie edited this page Aug 24, 2021 
        ·
        5 revisions
      
    Component visual QA should be done to cover the following aspects:
-  Beyond max
-  max
-  xlg
-  lg
-  md
-  sm
- Default
- Hover
- Active
- Focus
- Keyboard navigation
-  Other non-universal states such as selectedin Table of content
- Minimal content
- Maximum content
- Text line wrap
- With & without optional content
- White theme
- Gray 10 theme
- Gray 90 theme
- Gray 100 theme
- On grid
- Names of component and variation demoed is spelled correctly
- Knobs are as expected and functional
- Default example demos usage intent
- Color: No hardcoded color value unless explicitly requested by design
- Typography: No hardcoded type styles unless explicitly requested by design
- Pass all checks (except Percy when style changes are expected)
- If PR addresses styling change, run a Percy test locally to catch obvious regressions.