Skip to content

Conversation

@m4olivei
Copy link
Contributor

Related Ticket(s)

ADCMS-6749

Description

Tangentially related to ADCMS-6749. This fix addresses the following error when bundling the video-cta-container component in some environments:

Uncaught (in promise) Error: The following properties on element c4d-video-cta-container will not trigger updates as expected because they are set using class fields: _embedMedia. Native class fields and some compiled output will overwrite accessors used for detecting changes. See https://lit.dev/msg/class-field-shadowing for more information.
    at C4DVideoCTAContainer2.performUpdate (chunk-4KQNGL43.js?v=fb1a7d37:1973:17)
    at C4DVideoCTAContainer2.scheduleUpdate (chunk-4KQNGL43.js?v=fb1a7d37:1938:17)
    at C4DVideoCTAContainer2.__enqueueUpdate (chunk-4KQNGL43.js?v=fb1a7d37:1914:25)

Changelog

Changed

  • Removes @state decorator from _embedMedia method.

@m4olivei m4olivei requested a review from a team as a code owner December 16, 2024 17:06
@m4olivei m4olivei requested review from Valentin-Sorin-Nicolae, andy-blum, bruno-amorim and marcelojcs and removed request for a team December 16, 2024 17:06
@m4olivei m4olivei added the test: CDN preview used for generating @carbon/ibmdotcom-web-components CDN for testing label Dec 16, 2024
@m4olivei m4olivei closed this Dec 16, 2024
@m4olivei m4olivei reopened this Dec 16, 2024
@netlify
Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for ibm-dotcom-web-components-react-wrap ready!

Name Link
🔨 Latest commit 1cd1926
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components-react-wrap/deploys/6762d54a5fddd3000817877f
😎 Deploy Preview https://deploy-preview-12168--ibm-dotcom-web-components-react-wrap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for ibm-dotcom-web-components ready!

Name Link
🔨 Latest commit 1cd1926
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components/deploys/6762d54af008140008aebae8
😎 Deploy Preview https://deploy-preview-12168--ibm-dotcom-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 16, 2024

Deploy preview created for package IBM.com Web Components Deploy Preview CDN:
https://ibmdotcom-cdn.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/12168/index.html

Built with commit: 1cd1926f3eaec1c2181a226ca0e86fb2c6ba61c2

@andy-blum andy-blum added the Ready to merge Label for the pull requests that are ready to merge label Dec 18, 2024
@kodiakhq kodiakhq bot merged commit 62fcdba into main Dec 18, 2024
20 checks passed
@kodiakhq kodiakhq bot deleted the fix/video-error branch December 18, 2024 14:19
@github-actions
Copy link
Contributor

Hey there! This issue/pull request was referenced in recently released v2.16.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: high Ready to merge Label for the pull requests that are ready to merge test: CDN preview used for generating @carbon/ibmdotcom-web-components CDN for testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants