Skip to content

feat: port CvTooltip to Vue3 #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 12, 2023
Merged

feat: port CvTooltip to Vue3 #1498

merged 8 commits into from
Aug 12, 2023

Conversation

OlkaB
Copy link
Contributor

@OlkaB OlkaB commented Jul 30, 2023

Contributes to #1489

## What did you do?
ported CvTooltip, CvDefinitionTooltip, CvInteractiveTooltip to Vue3

How have you tested it?

see src\components\CvTooltip_tests_\CvTooltip.spec.js

Were docs updated if needed?

  • Yes

@OlkaB OlkaB changed the title Feat: port CvTooltip to Vue3 feat: port CvTooltip to Vue3 Jul 30, 2023
@OlkaB OlkaB marked this pull request as ready for review August 4, 2023 18:58
Copy link
Contributor

@davidnixon davidnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great. Thanks! one small tweak please.

@OlkaB
Copy link
Contributor Author

OlkaB commented Aug 9, 2023

@davidnixon done

@@ -0,0 +1,15 @@
export const TipAlignments = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Just making a note here as it relates to #591

@davidnixon davidnixon merged commit 757af66 into carbon-design-system:vNext Aug 12, 2023
@OlkaB OlkaB mentioned this pull request Aug 13, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants