feat: implement CvToggle #1467
feat: implement CvToggle #1467
Conversation
Port CvToggle to Vue3
create index.js
Implement all v2 tests to v3 CvToggle component
Cv toggle vue3
| @@ -58,6 +58,7 @@ import CvSwitcherItemLink from './src/components/CvUIShell/CvSwitcherItemLink.vu | |||
| import CvColumn from './src/components/CvGrid/CvColumn.vue'; | |||
| import CvGrid from './src/components/CvGrid/CvGrid.vue'; | |||
| import CvRow from './src/components/CvGrid/CvRow.vue'; | |||
| import CvToggle from './src/components/CvToggle/CvToggle.vue'; | |||
There was a problem hiding this comment.
I should probably get rid of this file. I was using to debug stuff locally but its not used in packaging. For any other components that you work on you can skip adding them here.
| @@ -0,0 +1,29 @@ | |||
| <template> | |||
There was a problem hiding this comment.
This one is not working. BTW I don't think a skeleton toggle is a very common use case but it would be good to have it working for completeness. Here is what I see:
The react component looks OK
https://v7-react.carbondesignsystem.com/?path=/story/components-toggle--skeleton
Have a look there but they have the bx--skeleton on an input element.
|
@WesleyGazz you are right. This is broken in Vue2 as well. https://vue.carbondesignsystem.com/?path=/story/components-cvtoggle--skeleton Maybe we should merge this and just open an issue for Vue 2 & 3 regarding the skeleton. What do you think? |
|
@davidnixon I think it's a good idea, ok for me. Thanks |
Contributes to #1460
What did you do?
Implemented CvToggle to Carbon Vue3
Why did you do it?
To help community development
How have you tested it?
I Replicated unit tests from Vue2 to Vu3
Were docs updated if needed?