[mlp] add eui super select function to list registry options #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
vinoth-gojek
changed the title
bthari
reviewed
May 5, 2025
Contributor
bthari
left a comment
bthari
left a comment
There was a problem hiding this comment.
Thank you for fixing this one! LGTM 🚀
vinoth-gojek
added a commit
to caraml-dev/merlin
that referenced
this pull request
May 14, 2025
<!-- Thanks for sending a pull request! Here are some tips for you: 1. Run unit tests and ensure that they are passing 2. If your change introduces any API changes, make sure to update the e2e tests 3. Make sure documentation is updated for your PR! --> # Description The MR is to fix a bug - the bug crashes the ui on click of registries list The fix uses <euisuperselect /> component to fix the UI crash. The component to load the registries is loaded from pre-build package The relevant MLP MR - caraml-dev/mlp#118 # Checklist - [x] Added PR label - [ ] Added unit test, integration, and/or e2e tests - [x] Tested locally - [ ] Updated documentation - [ ] Update Swagger spec if the PR introduce API changes - [ ] Regenerated Golang and Python client if the PR introduces API changes --------- Co-authored-by: vinoth <[email protected]>
bthari
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix a bug - the bug crashes the ui on click of registries list
The fix uses component to fix the UI crash. The component to load the registries is loaded from pre-build package
The relevant Merlin MR - caraml-dev/merlin#646
Change to ci files: