Skip to content

feat: replace hardcoded values in kafka_sink, change default partitions to 3 #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 7, 2025
Merged

feat: replace hardcoded values in kafka_sink, change default partitions to 3 #654

merged 2 commits into from
Aug 7, 2025

Conversation

@shydefoo
Copy link
Contributor

@shydefoo shydefoo commented Aug 4, 2025 •
edited
Loading

Description

  • This PR replaces the hardcoded values with environment variables that default to the original values
  • Replace the default number of partitions from 24 to 3.

Modifications

Tests

Checklist

  • Added PR label
  • Added unit test, integration, and/or e2e tests
  • Tested locally
  • Updated documentation
  • Update Swagger spec if the PR introduce API changes
  • Regenerated Golang and Python client if the PR introduces API changes

Release Notes

@shydefoo shydefoo added the maintenance Dependency updates and other chores label Aug 4, 2025
@shydefoo shydefoo self-assigned this Aug 4, 2025
@shydefoo shydefoo requested a review from deadlycoconuts August 4, 2025 09:43
deadlycoconuts
deadlycoconuts approved these changes Aug 5, 2025
View reviewed changes
Copy link
Contributor

@deadlycoconuts deadlycoconuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow thanks for refactoring the hardcoded default values away! 🙏🏼🚀

@shydefoo shydefoo changed the title feat: change numPartitions for kafka topic from 24 to 3 feat: replace hardcoded values in kafka_sink, change default partitions to 3 Aug 7, 2025
@shydefoo shydefoo merged commit ade3fdc into main Aug 7, 2025
62 of 64 checks passed
@shydefoo shydefoo deleted the modify-mlobs-partition-config branch August 7, 2025 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deadlycoconuts deadlycoconuts deadlycoconuts approved these changes

Assignees

@shydefoo shydefoo

Labels

maintenance Dependency updates and other chores

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shydefoo @deadlycoconuts