Fixes the exportAll -> export_all outline API change #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As until now the client implementation replaced single underscores with a dot this was not compatible with underscores in the API URIs. For this reason now double underscores in the method name are replaced with a dot instead.
Closed
|
Why does this not get merged? I currently have no test instance to test this pr. But this would be extremely helpful if this gets back to working state. |
|
@Mag1cByt3s feel free to use this docker image for testing this pr: ghcr.io/dhx/outliner:main @captn3m0 any suggestions how to get this merged are welcome :) |
|
Was on vacation till recently. Will review and merge this soon.
|
|
Testing this against the a getoutline.com hosted instance, and the Redirect Fileoperation request keeps erroring out at CloudFront: Seeing if I can add a workaround for this. |
|
HTTParty is re-sending the request body over the 302 and that causes cloudfront to trip and return a 403. Found an upstream issue: jnunemaker/httparty#783 |
Fixes redirect issues. httparty sends request body at 302 redirects, so we disable redirect follows for our fileoperations.redirect call. minor changes in client as well: 1. drops the token from the body, and sends it in header instead as per the new api 2. support additional options
captn3m0
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems the outline API has changed the collections export endpoint as of ( outline/openapi@ef782ca#diff-543af4ad11a870531a5ccc129b39a1b4d2c7860812f2015b697524c5d636f800R1084 ) - now we have to check the created FileOperation for completion before we can download the zip file.
Necessary change introduced in this PR:
As until now the client implementation replaced single underscores with a dot this was not compatible with underscores in the API URIs. Because of that only double underscores in the method name should be replaced with a dot instead.