audit-logging/srv/log2restv2.js - circular dependency in error case

[soccermax]

      res.on('end', () => {
        let body = Buffer.concat(chunks).toString()
        if (res.headers['content-type']?.match(/json/)) body = JSON.parse(body)
        if (res.statusCode >= 400) {
          const err = new Error(res.statusMessage)
          err.response = res
          err.body = body
          reject(err)
        } else {
          resolve(body)
        }
      })

err.response --> contains circular dependencies. This results in an error if we try to log the error.

[oklemenz2]

Any update, when this will be implemented? err should be serializable ...

[sjvans]

hi @soccermax @oklemenz2

imho a logger should be able to deal with circular jsons. or in other words: you shouldn't (have to) worry about what a/ your logger can deal with when constructing errors... but the circular structure in this case doesn't contain any important information other than maybe request url, etc., which we can add to the error directly, which should solve your issue while also reducing clutter.

best,
sebastian