Skip to content

Cleans up containers and shims on microk8s stop and snap removal #4755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2024
Merged

Cleans up containers and shims on microk8s stop and snap removal #4755

merged 1 commit into from
Nov 29, 2024

Conversation

claudiubelu
Copy link
Contributor

@claudiubelu claudiubelu commented Nov 25, 2024 •
edited
Loading

Summary

The containerd shims and the containers are now removed in both classic and strict modes when stopping microk8s (microk8s stop) or when removing the snap.

Note that ctr container delete has no --force flag.

Adds additional assertion in the upgrade test, ensuring that the Pods / containers have been removed on snap removal.

Adds additional test, ensuring that the Pods / containers have been removed when running microk8s stop.

Changes

The Kubernetes-related containers / Pods are now stopped when running microk8s stop. The same containers / Pods are no longer leaked on snap removal.

Testing

Added extra assertions and integration test to ensure the new behaviour.

Possible Regressions

Checklist

  • Read the contributions page.
  • Submitted the CLA form, if you are a first time contributor.
  • The introduced changes are covered by unit and/or integration tests.

Notes

Inspired by: #4693
Closes: #3969

@claudiubelu
Cleans up containers and shims on microk8s stop and snap removal
d7bbea1 
The containerd shims and the containers are now removed in both classic
and strict modes when stopping microk8s (microk8s stop) or when removing
the snap.

Note that ctr container delete has no ``--force`` flag.

Adds additional assertion in the upgrade test, ensuring that the Pods /
containers have been removed on snap removal.

Adds additional test, ensuring that the Pods / containers have been
removed when running microk8s stop.
bschimke95
bschimke95 approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bschimke95 bschimke95 merged commit 941b781 into canonical:master Nov 29, 2024
10 of 11 checks passed
@abhilashshetty04
Copy link

Hi Folks, Is this part of any release yet?

@mathnitin
Copy link

Will this be available for microk8s 1.30 release? If so, can we please have a date

@ktsakalozos
Copy link
Member

@abhilashshetty04 @mathnitin this work will initially ship with the 1.32 release. Assuming we do not run into any issues with it we will consider backporting it to older releases.

@berkayoz berkayoz mentioned this pull request Dec 12, 2024
Merged
berkayoz pushed a commit to berkayoz/microk8s that referenced this pull request Feb 14, 2025
@claudiubelu @berkayoz
Cleans up containers and shims on microk8s stop and snap removal (can…
611c117 
…onical#4755)

The containerd shims and the containers are now removed in both classic
and strict modes when stopping microk8s (microk8s stop) or when removing
the snap.

Note that ctr container delete has no ``--force`` flag.

Adds additional assertion in the upgrade test, ensuring that the Pods /
containers have been removed on snap removal.

Adds additional test, ensuring that the Pods / containers have been
removed when running microk8s stop.

(cherry picked from commit 941b781)
berkayoz pushed a commit to berkayoz/microk8s that referenced this pull request Feb 14, 2025
@claudiubelu @berkayoz
Cleans up containers and shims on microk8s stop and snap removal (can…
eebcb5f 
…onical#4755)

The containerd shims and the containers are now removed in both classic
and strict modes when stopping microk8s (microk8s stop) or when removing
the snap.

Note that ctr container delete has no ``--force`` flag.

Adds additional assertion in the upgrade test, ensuring that the Pods /
containers have been removed on snap removal.

Adds additional test, ensuring that the Pods / containers have been
removed when running microk8s stop.

(cherry picked from commit 941b781)
berkayoz pushed a commit to berkayoz/microk8s that referenced this pull request Feb 14, 2025
@claudiubelu @berkayoz
Cleans up containers and shims on microk8s stop and snap removal (can…
e4dc0a5 
…onical#4755)

The containerd shims and the containers are now removed in both classic
and strict modes when stopping microk8s (microk8s stop) or when removing
the snap.

Note that ctr container delete has no ``--force`` flag.

Adds additional assertion in the upgrade test, ensuring that the Pods /
containers have been removed on snap removal.

Adds additional test, ensuring that the Pods / containers have been
removed when running microk8s stop.

(cherry picked from commit 941b781)
berkayoz pushed a commit to berkayoz/microk8s that referenced this pull request Feb 14, 2025
@claudiubelu @berkayoz
Cleans up containers and shims on microk8s stop and snap removal (can…
d234c10 
…onical#4755)

The containerd shims and the containers are now removed in both classic
and strict modes when stopping microk8s (microk8s stop) or when removing
the snap.

Note that ctr container delete has no ``--force`` flag.

Adds additional assertion in the upgrade test, ensuring that the Pods /
containers have been removed on snap removal.

Adds additional test, ensuring that the Pods / containers have been
removed when running microk8s stop.

(cherry picked from commit 941b781)
berkayoz pushed a commit that referenced this pull request Feb 14, 2025
@claudiubelu @berkayoz
Cleans up containers and shims on microk8s stop and snap removal (#4755)
12480b8 
The containerd shims and the containers are now removed in both classic
and strict modes when stopping microk8s (microk8s stop) or when removing
the snap.

Note that ctr container delete has no ``--force`` flag.

Adds additional assertion in the upgrade test, ensuring that the Pods /
containers have been removed on snap removal.

Adds additional test, ensuring that the Pods / containers have been
removed when running microk8s stop.

(cherry picked from commit 941b781)
berkayoz pushed a commit that referenced this pull request Feb 14, 2025
@claudiubelu @berkayoz
Cleans up containers and shims on microk8s stop and snap removal (#4755)
34d9c65 
The containerd shims and the containers are now removed in both classic
and strict modes when stopping microk8s (microk8s stop) or when removing
the snap.

Note that ctr container delete has no ``--force`` flag.

Adds additional assertion in the upgrade test, ensuring that the Pods /
containers have been removed on snap removal.

Adds additional test, ensuring that the Pods / containers have been
removed when running microk8s stop.

(cherry picked from commit 941b781)
berkayoz pushed a commit that referenced this pull request Feb 14, 2025
@claudiubelu @berkayoz
Cleans up containers and shims on microk8s stop and snap removal (#4755)
4230f04 
The containerd shims and the containers are now removed in both classic
and strict modes when stopping microk8s (microk8s stop) or when removing
the snap.

Note that ctr container delete has no ``--force`` flag.

Adds additional assertion in the upgrade test, ensuring that the Pods /
containers have been removed on snap removal.

Adds additional test, ensuring that the Pods / containers have been
removed when running microk8s stop.

(cherry picked from commit 941b781)
berkayoz pushed a commit that referenced this pull request Feb 14, 2025
@claudiubelu @berkayoz
Cleans up containers and shims on microk8s stop and snap removal (#4755)
77596a8 
The containerd shims and the containers are now removed in both classic
and strict modes when stopping microk8s (microk8s stop) or when removing
the snap.

Note that ctr container delete has no ``--force`` flag.

Adds additional assertion in the upgrade test, ensuring that the Pods /
containers have been removed on snap removal.

Adds additional test, ensuring that the Pods / containers have been
removed when running microk8s stop.

(cherry picked from commit 941b781)
This was referenced Feb 14, 2025
Merged
Merged
Merged
Merged
berkayoz added a commit that referenced this pull request Feb 17, 2025
@berkayoz @claudiubelu
[Backport 1.31] Cleans up containers and shims on microk8s stop and s…
b417706 
…nap removal (#4880)

* Cleans up containers and shims on microk8s stop and snap removal (#4755)

The containerd shims and the containers are now removed in both classic
and strict modes when stopping microk8s (microk8s stop) or when removing
the snap.

Note that ctr container delete has no ``--force`` flag.

Adds additional assertion in the upgrade test, ensuring that the Pods /
containers have been removed on snap removal.

Adds additional test, ensuring that the Pods / containers have been
removed when running microk8s stop.

(cherry picked from commit 941b781)

* Add psutil to pip install directives (#4782)

(cherry picked from commit e2b2a2f)

---------

Co-authored-by: Claudiu Belu <[email protected]>
berkayoz added a commit that referenced this pull request Feb 17, 2025
@berkayoz @claudiubelu
[Backport 1.31-strict] Cleans up containers and shims on microk8s sto…
68bd94c 
…p and snap removal (#4881)

* Cleans up containers and shims on microk8s stop and snap removal (#4755)

The containerd shims and the containers are now removed in both classic
and strict modes when stopping microk8s (microk8s stop) or when removing
the snap.

Note that ctr container delete has no ``--force`` flag.

Adds additional assertion in the upgrade test, ensuring that the Pods /
containers have been removed on snap removal.

Adds additional test, ensuring that the Pods / containers have been
removed when running microk8s stop.

(cherry picked from commit 941b781)

* Add psutil to pip install directives (#4782)

(cherry picked from commit e2b2a2f)

---------

Co-authored-by: Claudiu Belu <[email protected]>
berkayoz added a commit that referenced this pull request Feb 17, 2025
@berkayoz @claudiubelu @ktsakalozos
[Backport 1.30] Cleans up containers and shims on microk8s stop and s…
940819c 
…nap removal (#4882)

* Cleans up containers and shims on microk8s stop and snap removal (#4755)

The containerd shims and the containers are now removed in both classic
and strict modes when stopping microk8s (microk8s stop) or when removing
the snap.

Note that ctr container delete has no ``--force`` flag.

Adds additional assertion in the upgrade test, ensuring that the Pods /
containers have been removed on snap removal.

Adds additional test, ensuring that the Pods / containers have been
removed when running microk8s stop.

(cherry picked from commit 941b781)

* Add psutil to pip install directives (#4782)

(cherry picked from commit e2b2a2f)

* Disable testing on debian and centos. Images missing. (#4606)

(cherry picked from commit 81d5d0a)

---------

Co-authored-by: Claudiu Belu <[email protected]>
Co-authored-by: Konstantinos Tsakalozos <[email protected]>
berkayoz added a commit that referenced this pull request Feb 17, 2025
@berkayoz @claudiubelu
[Backport 1.30-strict] Cleans up containers and shims on microk8s sto…
6e978f7 
…p and snap removal (#4883)

* Cleans up containers and shims on microk8s stop and snap removal (#4755)

The containerd shims and the containers are now removed in both classic
and strict modes when stopping microk8s (microk8s stop) or when removing
the snap.

Note that ctr container delete has no ``--force`` flag.

Adds additional assertion in the upgrade test, ensuring that the Pods /
containers have been removed on snap removal.

Adds additional test, ensuring that the Pods / containers have been
removed when running microk8s stop.

(cherry picked from commit 941b781)

* Add psutil to pip install directives (#4782)

(cherry picked from commit e2b2a2f)

---------

Co-authored-by: Claudiu Belu <[email protected]>
@ktsakalozos ktsakalozos mentioned this pull request Feb 24, 2025
Closed
3 tasks
berkayoz added a commit that referenced this pull request Mar 25, 2025
@berkayoz
fix: flush the CNI-HOSTPORT-DNAT chain on stop
3cb3109 
`microk8s stop` was changed to fully remove containers via ctr(#4755)
which results in an old DNAT rule getting left-over that points
to the old container id. flushing the chain should fix issues of
hostPort connections dropping after a stop & start.
This was referenced Mar 25, 2025
Merged
Closed
berkayoz added a commit that referenced this pull request Mar 26, 2025
@berkayoz
fix: flush the CNI-HOSTPORT-DNAT chain on stop (#4963)
b170cad 
`microk8s stop` was changed to fully remove containers via ctr(#4755)
which results in an old DNAT rule getting left-over that points
to the old container id. flushing the chain should fix issues of
hostPort connections dropping after a stop & start.
berkayoz added a commit that referenced this pull request Mar 26, 2025
@berkayoz
fix: flush the CNI-HOSTPORT-DNAT chain on stop (#4963)
459940a 
`microk8s stop` was changed to fully remove containers via ctr(#4755)
which results in an old DNAT rule getting left-over that points
to the old container id. flushing the chain should fix issues of
hostPort connections dropping after a stop & start.

(cherry picked from commit b170cad)
berkayoz added a commit that referenced this pull request Mar 26, 2025
@berkayoz
fix: flush the CNI-HOSTPORT-DNAT chain on stop (#4963)
1387759 
`microk8s stop` was changed to fully remove containers via ctr(#4755)
which results in an old DNAT rule getting left-over that points
to the old container id. flushing the chain should fix issues of
hostPort connections dropping after a stop & start.

(cherry picked from commit b170cad)
berkayoz added a commit that referenced this pull request Mar 26, 2025
@berkayoz
fix: flush the CNI-HOSTPORT-DNAT chain on stop (#4963)
97a87d8 
`microk8s stop` was changed to fully remove containers via ctr(#4755)
which results in an old DNAT rule getting left-over that points
to the old container id. flushing the chain should fix issues of
hostPort connections dropping after a stop & start.

(cherry picked from commit b170cad)
berkayoz added a commit that referenced this pull request Mar 26, 2025
@berkayoz
fix: flush the CNI-HOSTPORT-DNAT chain on stop (#4963)
acdc588 
`microk8s stop` was changed to fully remove containers via ctr(#4755)
which results in an old DNAT rule getting left-over that points
to the old container id. flushing the chain should fix issues of
hostPort connections dropping after a stop & start.

(cherry picked from commit b170cad)
berkayoz added a commit that referenced this pull request Mar 26, 2025
@berkayoz
fix: flush the CNI-HOSTPORT-DNAT chain on stop (#4963)
e995a98 
`microk8s stop` was changed to fully remove containers via ctr(#4755)
which results in an old DNAT rule getting left-over that points
to the old container id. flushing the chain should fix issues of
hostPort connections dropping after a stop & start.

(cherry picked from commit b170cad)
berkayoz added a commit that referenced this pull request Mar 26, 2025
@berkayoz
fix: flush the CNI-HOSTPORT-DNAT chain on stop (#4963)
91c9912 
`microk8s stop` was changed to fully remove containers via ctr(#4755)
which results in an old DNAT rule getting left-over that points
to the old container id. flushing the chain should fix issues of
hostPort connections dropping after a stop & start.

(cherry picked from commit b170cad)
This was referenced Mar 26, 2025
Merged
Merged
Merged
Merged
Merged
Merged
berkayoz added a commit that referenced this pull request Mar 27, 2025
@berkayoz
fix: flush the CNI-HOSTPORT-DNAT chain on stop (#4963) (#4966)
b71716d 
`microk8s stop` was changed to fully remove containers via ctr(#4755)
which results in an old DNAT rule getting left-over that points
to the old container id. flushing the chain should fix issues of
hostPort connections dropping after a stop & start.

(cherry picked from commit b170cad)
berkayoz added a commit that referenced this pull request Mar 27, 2025
@berkayoz
fix: flush the CNI-HOSTPORT-DNAT chain on stop (#4963) (#4967)
6a4130e 
`microk8s stop` was changed to fully remove containers via ctr(#4755)
which results in an old DNAT rule getting left-over that points
to the old container id. flushing the chain should fix issues of
hostPort connections dropping after a stop & start.

(cherry picked from commit b170cad)
berkayoz added a commit that referenced this pull request Mar 27, 2025
@berkayoz
fix: flush the CNI-HOSTPORT-DNAT chain on stop (#4963) (#4968)
3030ce4 
`microk8s stop` was changed to fully remove containers via ctr(#4755)
which results in an old DNAT rule getting left-over that points
to the old container id. flushing the chain should fix issues of
hostPort connections dropping after a stop & start.

(cherry picked from commit b170cad)
berkayoz added a commit that referenced this pull request Mar 27, 2025
@berkayoz
fix: flush the CNI-HOSTPORT-DNAT chain on stop (#4963) (#4969)
1b18560 
`microk8s stop` was changed to fully remove containers via ctr(#4755)
which results in an old DNAT rule getting left-over that points
to the old container id. flushing the chain should fix issues of
hostPort connections dropping after a stop & start.

(cherry picked from commit b170cad)
berkayoz added a commit that referenced this pull request Mar 27, 2025
@berkayoz
fix: flush the CNI-HOSTPORT-DNAT chain on stop (#4963) (#4970)
c7d337f 
`microk8s stop` was changed to fully remove containers via ctr(#4755)
which results in an old DNAT rule getting left-over that points
to the old container id. flushing the chain should fix issues of
hostPort connections dropping after a stop & start.

(cherry picked from commit b170cad)
berkayoz added a commit that referenced this pull request Mar 27, 2025
@berkayoz
fix: flush the CNI-HOSTPORT-DNAT chain on stop (#4963) (#4971)
b7e4aae 
`microk8s stop` was changed to fully remove containers via ctr(#4755)
which results in an old DNAT rule getting left-over that points
to the old container id. flushing the chain should fix issues of
hostPort connections dropping after a stop & start.

(cherry picked from commit b170cad)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bschimke95 bschimke95 bschimke95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

microk8s stop command does not shutdown previous deployed containers
5 participants
@claudiubelu @abhilashshetty04 @mathnitin @ktsakalozos @bschimke95