rook-ceph: Update addon to v1.16.6 #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer notes regarding this update: - .rook-create-external-cluster-resources.py: it now matches upstream's v1.16.6 script (the --keyring PR merged upstream, as well as IPv6 support). - connect-external-ceph: if an error occurs while calling .rook-create-external-cluster-resources.py, we now log its stdout and stderr, which were not logged previously. This demystifies potentials errors. - validators.py: in validate_rook_ceph_integration, we now enable prometheus, which is now required, as noted below. Notable updates: - .rook-create-external-cluster-resources.py: If a --monitoring-endpoint option is not given, the script will try to automatically find one. If it is not found, an ExecutionFailureException is now raised (it was not previously).
|
Note that the test |
bschimke95
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer notes regarding this update:
.rook-create-external-cluster-resources.py: it now matches upstream's v1.16.6 script (the--keyringPR merged upstream, as well as IPv6 support).connect-external-ceph: if an error occurs while calling.rook-create-external-cluster-resources.py, we now log itsstdoutandstderr, which were not logged previously. This demystifies potentials errors.validators.py: invalidate_rook_ceph_integration, we now enableprometheus, which is now required, as noted below.Notable updates:
.rook-create-external-cluster-resources.py: If a--monitoring-endpointoption is not given, the script will try to automatically find one. If it is not found, anExecutionFailureExceptionis now raised (it was not previously).Also verify you have: