Skip to content

Conversation

@orfeas-k
Copy link
Contributor

@orfeas-k orfeas-k commented Sep 22, 2023

This PR updates Katib ROCKs for CKF release 1.8. Details in #31.
Bumped all ROCKs with following exceptions:

Fixes #31

Testing

Since there are no integration tests in place at the moment, the ROCKs were built and tested using the following commands (as instructed here in Basic Testing section)

export ROCK=<rockname without .rock>
sudo skopeo --insecure-policy copy oci-archive:${ROCK}.rock docker-daemon:${ROCK}:rock
docker run ${ROCK}:rock exec <service-command>
docker run ${ROCK}:rock exec pebble restart <service-name>
docker run ${ROCK}:rock exec pebble plan

Remove this ROCK since upstream has consolidated it into the
katib-controller.
Ref kubeflow/katib/pull/2185
@orfeas-k orfeas-k marked this pull request as ready for review September 25, 2023 15:16
@orfeas-k orfeas-k requested a review from a team as a code owner September 25, 2023 15:16
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @orfeas-k, this looks good, though I'd wait for @i-chvets' review just to confirm everything is alright.

@i-chvets
Copy link
Contributor

i-chvets commented Sep 28, 2023

One ROCK is missing from this update: https://github.com/canonical/katib-rocks/blob/kf-4177-update-katib-rocks-for-ckf-1.8/suggestion-goptuna/rockcraft.yaml suggestion-goptuna is already at correct version.

All other ROCKs built fine.

Copy link
Contributor

@i-chvets i-chvets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@orfeas-k orfeas-k merged commit b4025fc into main Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Katib ROCKs to 0.16-rc.1 for CKF release 1.8

4 participants