vlan and bond support in networkd #6324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshedi
force-pushed
the
vlan-networkd
branch
6 times, most recently
from
82c09ae to
b1ac8af
Compare
Contributor
Author
|
@TheRealFalcon @holmanb Can you PTAL at this PR? I'm not sure if the failure is legit. If not, please take this fix if things look good. Thanks. |
sshedi
force-pushed
the
vlan-networkd
branch
3 times, most recently
from
89d66a9 to
7576d8f
Compare
TheRealFalcon
suggested changes
Jul 31, 2025
Contributor
TheRealFalcon
left a comment
TheRealFalcon
left a comment
There was a problem hiding this comment.
@sshedi , I left some comments inline, but overall things look good!
Contributor
Author
Thank you so much for the review and inputs. Tried addressing all your suggestions. PTAL when you get time. |
sshedi
force-pushed
the
vlan-networkd
branch
2 times, most recently
from
28317db to
2fc6c0e
Compare
Signed-off-by: Shreenidhi Shedi <[email protected]>
Signed-off-by: Shreenidhi Shedi <[email protected]>
DarkPhily
pushed a commit
to hetznercloud/cloud-init
that referenced
this pull request
Sep 2, 2025
Networkd renderer used in Photon OS doesn't support vlan and bond settings specified through network config yaml. This is an effort towards supporting the same in networkd renderer. Signed-off-by: Shreenidhi Shedi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
feat(networkd): support vlan and bond rendering
Additional Context
Test Steps
Merge type