Skip to content

Conversation

@dankm
Copy link
Contributor

@dankm dankm commented Nov 1, 2024

Implement the "optional" ethernet interface property from NetPlan for the networkd renderer. Marks an interface as not required for the network-online target using the RequiredForOnline=no Link property.

Proposed Commit Message

feat(networkd): Support RequiredForOnline link option

This allows an administrator to specify that an interface may not be available at
boot time, so we can avoid hanging while we wait for a configuration that might
never happen.

Test Steps

Using the networkd renderer, add an optional: true property to an interface. See that networkd no longer blocks the boot waiting for it to be configured.

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

Implement the "optional" ethernet interface property for the networkd
renderer. Marks an interface as not required for the network-online
target.
@github-actions github-actions bot added the documentation This Pull Request changes documentation label Nov 1, 2024
@TheRealFalcon TheRealFalcon self-assigned this Nov 5, 2024
Copy link
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! Overall, everything looks good.

Can you also add the new key to the network config v2 schema? Otherwise, specifying the key will result in a warning.

@dankm
Copy link
Contributor Author

dankm commented Nov 5, 2024

Not a problem. I thought about adding it the first time, but wasn't sure how to test it, or if it was necessary. Thanks.

Copy link
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@TheRealFalcon TheRealFalcon merged commit aeccf89 into canonical:main Nov 5, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation This Pull Request changes documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants