[IMP] change the names of the intermediate databases #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
having a number in the db name makes it easier to understand the order of the steps
sebalix
reviewed
Aug 26, 2025
Comment on lines
+183
to
+184
| ctx.obj["db_c2c_cleanup"] = ctx.obj["db_name"] + "_7_cleanup" | ||
| ctx.obj["db_c2c_migrated"] = ctx.obj["db_name"] + "_8_c2c_migrated" |
There was a problem hiding this comment.
In fact, cleanup and c2c_migrated are the same thing, the first is the name of the step (and DB snapshot by extension), and the last one is used to generate the .pg file (from cleanup snapshot) on disk to be self-explanatory (odoo_migrated.pg / c2c_migrated.pg).
We could rework that for sure, but here better to remove the _8 prefix in db_c2c_migrated as it's not used to generate DB snapshots.
sebalix
reviewed
Aug 26, 2025
| ctx.obj["db_c2c_migrated"] = ctx.obj["db_name"] + "_c2c_migrated" | ||
| ctx.obj["db_prod"] = ctx.obj["db_name"] + "_1_prod" | ||
| ctx.obj["db_prod_fixed"] = ctx.obj["db_name"] + "_2_prod_fixed" | ||
| ctx.obj["db_odoo_migrated"] = ctx.obj["db_name"] + "_3_odoo_migrated" |
There was a problem hiding this comment.
As this parameter is also used to generate the _odoo_migrated.pg dump file, we'll get a _3_odoo_migrated.pg instead here. Not really an issue that said.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
having a number in the db name makes it easier to understand the order of the steps