Skip to content

adding launch parameter to allow remote access to containerized OWL #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

adding launch parameter to allow remote access to containerized OWL #401

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion owl/webapp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1294,7 +1294,13 @@ def main():
app = create_ui()

app.queue()
app.launch(share=False, favicon_path="../assets/owl-favicon.ico")
launch_kwargs = {
"share": False,
"favicon_path": "../assets/owl-favicon.ico"
}
if os.getenv("OWL_SERVER_NAME") is not None:
launch_kwargs["server_name"] = os.getenv("OWL_SERVER_NAME")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OWL_SERVER_NAME should be validated to confirm it is a valid hostname or IP address

app.launch(**launch_kwargs)
except Exception as e:
logging.error(f"Error occurred while starting the application: {str(e)}")
print(f"Error occurred while starting the application: {str(e)}")
Expand Down