feat: properly retrieve displayScale for visionOS #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This PR is also reflected as a PR to Core: facebook#41214 I will remove |
matthargett
approved these changes
Oct 27, 2023
Collaborator
matthargett
left a comment
matthargett
left a comment
There was a problem hiding this comment.
Is there anything visual we can see a difference on in the tester app?
Member
Author
|
@matthargett I think we are close to merging this PR to core: facebook#41214 - So I think I will hold with merging this PR (I've added more extensive description there) |
Member
Author
|
The original PR got merged to core. I'm closing this one and will do a rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Goal of this PR is to properly retrieve
displayScalefor visionOS. It replaces usages of[[UIScreen mainScreen] scale].Changelog:
[VISIONOS] [FIXED] - properly retrieve displayScale for visionOS
Test Plan:
Check if
useWindowDimensionsHookreturns proper displayScale