Improve quote behavior of CURRENT_TIMESTAMP default #2389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mark Scherer <[email protected]> Signed-off-by: Matthew Peveler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1891
This is a port of cakephp/migrations#923 with some additional changes.
PR improves the behavior of how we handle the string
"CURRENT_TIMESTAMP"as a default such that it will now only not be quote if the column type is explicitlydatetime,timestamp,date, ortime. This should make behavior across adapters consistent where for mysql usingCURRENT_TIMESTAMPwith a string column would throw an error while postgres would implicitly cast it to a string.I've also added similar behavior to the
CURRENT_DATETIME,CURRENT_TIME,CURRENT_DATE, andNOWfunctions since those are also somewhat common in my experience as defaults fordatetime,time, anddaterespectfully.