Only include plugin tables (with files) in diff. #879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstory
reviewed
Aug 6, 2025
Comment on lines
+215
to
+234
| $connection->execute('CREATE TABLE IF NOT EXISTS articles ( | ||
| id INT AUTO_INCREMENT PRIMARY KEY, | ||
| title VARCHAR(255) | ||
| )'); | ||
|
|
||
| // Create a table that does NOT have a Table class in the TestBlog plugin | ||
| $connection->execute('CREATE TABLE IF NOT EXISTS orphan_table ( | ||
| id INT AUTO_INCREMENT PRIMARY KEY, | ||
| name VARCHAR(255) | ||
| )'); | ||
|
|
||
| // Create plugin migration history table | ||
| $connection->execute('CREATE TABLE IF NOT EXISTS test_blog_phinxlog ( | ||
| version BIGINT NOT NULL, | ||
| migration_name VARCHAR(100) DEFAULT NULL, | ||
| start_time TIMESTAMP DEFAULT CURRENT_TIMESTAMP, | ||
| end_time TIMESTAMP DEFAULT CURRENT_TIMESTAMP, | ||
| breakpoint TINYINT(1) NOT NULL DEFAULT 0, | ||
| PRIMARY KEY (version) | ||
| )'); |
There was a problem hiding this comment.
This SQL isn't going to work across platforms. You'll either need to generalize it quite a bit, or make this test conditional for MySQL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #325
I gave claude.ai the following instructions
@ADmad What do you think?
In general this should probably be a flag/option of sorts, as this could be useful in both directions, and also for app (to exclude plugin ones?)