GH4642: Standardize execution status display in report printers #4644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jericho
previously requested changes
Oct 31, 2025
Contributor
Jericho
left a comment
Jericho
left a comment
There was a problem hiding this comment.
Succeeded contains double 'c' and double 'e'
devlead
force-pushed
the
feature/gh-4642
branch
from
39e3dcb to
954adae
Compare
…inters
- Introduce ToReportStatus() extension method to standardize execution status display across both report printers, ensuring consistent formatting ("Succeeded", "Skipped", "Failed") instead of using enum ToString() directly.
- Add null argument validation to CakeSpectreReportPrinter and CakeReportPrinter constructors for improved defensive programming.
- Update CakeSpectreReportPrinter and CakeReportPrinter to use the new extension method for status formatting.
- Add test coverage for both printers including verbosity-based output verification.
- fixes cake-build#4642
- Fix typo
Co-authored-by: Jericho <[email protected]>
devlead
force-pushed
the
feature/gh-4642
branch
from
954adae to
d182fb1
Compare
This was referenced Nov 11, 2025
This was referenced Nov 11, 2025
This was referenced Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize execution status display in report printers