Skip to content

use AppendJoin #4569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

use AppendJoin #4569

wants to merge 1 commit into from

Conversation

SimonCropp
Copy link
Contributor

No description provided.

devlead
devlead requested changes Aug 27, 2025
View reviewed changes
Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request Changes

Technical Review: ✅ Good optimization - using AppendJoin for better performance.

Process Issues:

  • ❌ Missing Issue Link: This PR must be linked to an issue describing the modernization effort
  • ❌ Insufficient Description: PR description should explain the performance benefits
  • ✅ CI Status: All checks passing

Recommendation: Please create an issue describing the .NET modernization effort and link it to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devlead devlead devlead requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonCropp @devlead